This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Rename tree_ssa_useless_type_conversion_1
On Fri, 22 Jun 2007, Diego Novillo wrote:
> On 6/22/07 5:35 AM, Richard Guenther wrote:
>
> > *** gcc.orig/tree-cfg.c 2007-06-21 16:54:03.000000000 +0200
> > --- gcc/tree-cfg.c 2007-06-21 16:54:16.000000000 +0200
> > *************** verify_expr (tree *tp, int *walk_subtree
> > *** 3287,3294 ****
> > }
> > /* Check to make sure the second operand is an integer with type of
> > sizetype. */
> > ! if (!tree_ssa_useless_type_conversion_1 (sizetype,
> > ! TREE_TYPE (TREE_OPERAND (t, 1))))
> > {
> > error ("invalid operand to pointer plus, second operand is not an "
> > "integer with type of sizetype.");
> > --- 3287,3294 ----
> > }
> > /* Check to make sure the second operand is an integer with type of
> > sizetype. */
> > ! if (!!type_conversion_needed_p (sizetype,
> > ! TREE_TYPE (TREE_OPERAND (t, 1))))
>
> No double negation, please.
Whoops ;) Fixed.
> Other than that, it looks fine to me, but it may be better to wait until
> the freeze.
Ok.
> Renaming tree_ssa_useless_type_conversion comes in another
> patch?
I still have to create it (as well as capturing the symmetric case of
type_conversion_needed_p into sth like types_compatible_p). But yes,
that is the plan.
Richard.