This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix pthread_getattr_np call in boehm-gc
- From: Andrew Haley <aph-gcc at littlepinkcloud dot COM>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org, java-patches at gcc dot gnu dot org, Hans Boehm <Hans dot Boehm at hp dot com>
- Date: Fri, 22 Jun 2007 11:26:52 +0100
- Subject: Re: [PATCH] Fix pthread_getattr_np call in boehm-gc
- References: <20070622101932.GF7012@devserv.devel.redhat.com>
Jakub Jelinek writes:
> pthread_getattr_np can fail for various reasons and if it does,
> pthread_attr_t is uninitialized and therefore neither pthread_attr_getstack
> nor pthread_attr_destroy should be called on it.
> E.g. if pthread_getattr_np is called from the initial thread on Linux
> and /proc is not mapped, pthread_getattr_np will fail as /proc/self/maps
> couldn't be read, pthread_attr_getstack will then return random values
> and pthread_attr_destroy likely crash as it tries to free cpuset that wasn't
> malloced.
>
> Ok for 4.3/4.2/4.1?
>
> 2007-06-22 Jakub Jelinek <jakub@redhat.com>
>
> * pthread_support.c (GC_get_thread_stack_base): Handle
> pthread_getattr_np failures.
>
OK.
Andrew.