This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch,committed] Fix PR/target 32313, MIPS bootstrap failure running gengtype in stage 2.
- From: Eric Christopher <echristo at apple dot com>
- To: David Daney <ddaney at avtrex dot com>
- Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>, rsandifo at nildram dot co dot uk
- Date: Mon, 18 Jun 2007 11:37:41 -0700
- Subject: Re: [Patch,committed] Fix PR/target 32313, MIPS bootstrap failure running gengtype in stage 2.
- References: <4676C527.1060102@avtrex.com> <877iq1i14z.fsf@firetop.home> <4676CD3E.5090003@avtrex.com>
I don't think this is right. Locally-binding functions for -mno-
shared
should never use lazy-binding stubs, so should never need $gp to be
initialised on entry. (Functions called directly should intialise
$gp
if they need it.) In the PR, why does
get_output_file_with_visibility
need $gp to be initialised on entry?
Argh!. I may not have been thinking clearly. Let me look at this
again. It is possible that this is the problem that is fixed by:
http://gcc.gnu.org/ml/gcc-patches/2007-06/msg01252.html
If it is, I will revert this patch.
Should be on second thought since the problem you were working around
was that we were clobbering $gp in the case where we needed it, but
not registering the fact.
-eric