This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Patch: remove ObjC-related globals from C FE
- From: Matthew Wilcox <matthew at wil dot cx>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Fri, 15 Jun 2007 17:37:28 -0600
- Subject: Re: Patch: remove ObjC-related globals from C FE
Tom Tromey wrote:
> -static int objc_need_raw_identifier = 0;
> -#define OBJC_NEED_RAW_IDENTIFIER(VAL) \
> +#define OBJC_NEED_RAW_IDENTIFIER(PARSER, VAL) \
> do { \
> if (c_dialect_objc ()) \
> - objc_need_raw_identifier = VAL; \
> + parser->objc_need_raw_identifier = VAL; \
> } while (0)
s/parser/PARSER/
Of course, it happens to work because everywhere you're calling it,
your argument is actually called 'parser', but you obviously intended
to use parameter substitution, not magic names.