This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [REVISED PATCH][RFC] Fix PR c++/31923: Storage class with explicit template specialization


Simon Baldwin wrote:

> If we're sure that decl here is always a FUNCTION_DECL then the simpler
> condition ought to be fine.  I've retested with this change in place,
> and all regression tests continue to pass.

If GEN_TMPL (the most general template of which DECL is a
specialization) is DECL_FUNCTION_TEMPLATE_P then DECL had better be a
FUNCTION_DECL. :-)

> I could perhaps add suitable DejaGNU functions, but TCL/expect aren't my
> strong points.  Adding these functions might also be tricky for multiple
> architectures.  I didn't want this g++ patch to get hung up on testing
> framework changes that I might not be able to complete.  Can we live
> with this test for now?

This version is OK.

Thanks,

-- 
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]