This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [RFC,PATCH] 2 new mode attributes to replace mode(word) uses in libgcc
- From: Uros Bizjak <ubizjak at gmail dot com>
- To: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Cc: Andreas Krebbel <Andreas dot Krebbel at de dot ibm dot com>, Ian Lance Taylor <iant at google dot com>
- Date: Sat, 09 Jun 2007 11:26:18 +0200
- Subject: Re: [RFC,PATCH] 2 new mode attributes to replace mode(word) uses in libgcc
Hello!
I was wondering about prepare_float_lib_cmp. There is also used word_mode
as return mode which looks wrong to me since the eq<float mode> functions
in soft-fp are all defined with int as return type. So I've changed this
to TYPE_MODE (integer_type_node).
*** 4153,4159 ****
start_sequence ();
value = emit_library_call_value (libfunc, NULL_RTX, LCT_CONST,
! word_mode, 2, x, mode, y, mode);
insns = get_insns ();
end_sequence ();
--- 4154,4161 ----
start_sequence ();
value = emit_library_call_value (libfunc, NULL_RTX, LCT_CONST,
! TYPE_MODE (integer_type_node),
! 2, x, mode, y, mode);
insns = get_insns ();
end_sequence ();
This part is wrong, soft-fp should be fixed to return in word mode.
Please look at http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32268 and
http://sourceware.org/ml/libc-alpha/2007-06/msg00057.html
Uros.