This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch, fortran] Merge whitespace fixes from fortran-experiments branch
- From: Steve Kargl <sgk at troutmask dot apl dot washington dot edu>
- To: Brooks Moses <brooks dot moses at codesourcery dot com>
- Cc: fortran at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
- Date: Thu, 7 Jun 2007 07:49:54 -0700
- Subject: Re: [patch, fortran] Merge whitespace fixes from fortran-experiments branch
- References: <4667C9A1.1020002@codesourcery.com>
On Thu, Jun 07, 2007 at 02:02:25AM -0700, Brooks Moses wrote:
> Steve Kargl spent quite a lot of time fixing whitespace problems with
> the early versions of the ISO C binding implementation on the
> fortran-experiments branch. When I was reviewing the recent branch diff
> file, I noticed that he did a sufficiently good job of this that he also
> fixed quite a lot of problems that predated the ISO C binding work, and
> thus also exist on the trunk.
Actually, Christopher did some of the whitespace clean up
within the ICB parts of the patch. I simply finished
ferretting out anything that remained.
> Attached is a patch for trunk containing these whitespace fixes -- and,
> in particular, only the whitespace fixes that are sufficiently far away
> from the ISO C binding changes to avoid producing merge conflicts later.
> I've build-tested it on powerpc-apple-darwin8.9.0, and am currently
> regression-testing it. Ok to commit (assuming it passes reg-testing)?
yes.
> Steve, what's your preference for the name on the changelog -- am I
> correct in putting your name on it? (Or would you prefer that I take
> the blame in case something goes wrong? :) )
If these are the non ICB portions of the diff, then sure you
can blame me.
The patches I sent yesterday were mainly for testing not reviewing.
Stage 2 is coming soon, and I'd like to get this into 4.3.
--
Steve