This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] C++ fixed for tree-ssa*
- From: Diego Novillo <dnovillo at google dot com>
- To: Thomas Neumann <tneumann at users dot sourceforge dot net>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Wed, 06 Jun 2007 11:00:08 -0400
- Subject: Re: [PATCH] C++ fixed for tree-ssa*
- References: <f46dh8$rt8$1@sea.gmane.org>
On 6/6/07 9:40 AM, Thomas Neumann wrote:
> Tested on i686. Is this ok?
OK with some changes below:
> @@ -2395,14 +2395,14 @@ ccp_fold_builtin (tree stmt, tree fn)
> case BUILT_IN_STRLEN:
> if (val[0])
> {
> - tree new = fold_convert (TREE_TYPE (fn), val[0]);
> + tree new_tree = fold_convert (TREE_TYPE (fn), val[0]);
s/new_tree/new_val/
> void
> -merge_alias_info (tree orig, tree new)
> +merge_alias_info (tree orig, tree new_tree)
Better rename both arguments to 'orig_name' and 'new_name'.
> @@ -1239,7 +1239,7 @@ cprop_into_successor_phis (basic_block b
> indx = e->dest_idx;
> for ( ; phi; phi = PHI_CHAIN (phi))
> {
> - tree new;
> + tree new_tree;
s/new_tree/new_val/
> use_operand_p orig_p;
> tree orig;
You may want to s/orig/orig_val/ for consistency.
> @@ -1591,7 +1591,7 @@ record_equivalences_from_stmt (tree stmt
> && !is_gimple_reg (lhs))
> {
> tree rhs = GIMPLE_STMT_OPERAND (stmt, 1);
> - tree new;
> + tree new_tree;
s/new_tree/new_stmt/
> @@ -377,7 +377,7 @@ conditional_replacement (basic_block con
> {
> tree result;
> tree old_result = NULL;
> - tree new, cond;
> + tree new_tree, cond;
Likewise.
> @@ -624,7 +624,7 @@ minmax_replacement (basic_block cond_bb,
> tree arg0, tree arg1)
> {
> tree result, type;
> - tree cond, new;
> + tree cond, new_tree;
Likewise.