This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Your mangle_decl_assembler_name change broke "unaffected" targets.


On Thu, May 24, 2007 at 02:11:56PM +0200, Hans-Peter Nilsson wrote:
> (forgot to CC:, originally sent to dannysmith)
> 
> You really should have tested on a target that shouldn't have
> been affected by your change; I believe all of them broke.
> 
> Index: target-def.h
> 
> +#ifndef TARGET_MANGLE_DECL_ASSEMBLER_NAME
> +#define TARGET_MANGLE_DECL_ASSEMBLER_NAME mangle_decl_assembler_name
> +#endif
> +
> 
> I think that should have been default_mangle_decl_assembler_name

I saw

2007-05-24  Danny Smith  <dannysmith@users.sourceforge.net>

        PR target/27067
        * doc/tm.texi (TARGET_MANGLE_DECL_ASSEMBLER_NAME): Document.
        * targhooks.h (default_mangle_decl_assembler_name): Declare
        default hook.
        * targhooks.c (default_mangle_decl_assembler_name): Define
        default hook.
        * target-def.h (TARGET_MANGLE_DECL_ASSEMBLER_NAME) New. Set to
        default hook.

I am checking in this patch:

2007-05-24  H.J. Lu  <hongjiu.lu@intel.com>

	* target-def.h (TARGET_MANGLE_DECL_ASSEMBLER_NAME): Correct
	default hook.

--- gcc/target-def.h.hook	2007-05-24 06:33:42.000000000 -0700
+++ gcc/target-def.h	2007-05-24 07:29:39.000000000 -0700
@@ -465,7 +465,7 @@ Foundation, 51 Franklin Street, Fifth Fl
 #endif
 
 #ifndef TARGET_MANGLE_DECL_ASSEMBLER_NAME
-#define TARGET_MANGLE_DECL_ASSEMBLER_NAME mangle_decl_assembler_name
+#define TARGET_MANGLE_DECL_ASSEMBLER_NAME default_mangle_decl_assembler_name
 #endif
 
 #ifndef TARGET_ENCODE_SECTION_INFO


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]