This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH COMMITTED: Fix bug building complex C++ code


"Andrew Pinski" <pinskia@gmail.com> writes:

> On 22 May 2007 22:57:12 -0700, Ian Lance Taylor <iant@google.com> wrote:
> > This patch fixes an ICE reported by Tom Tromey on some complicated C++
> > test case.  I don't have a test case.  Tom tested the patch and
> > confirmed that it fixed the problem he saw.
> 
> You know there are programs which can help you reduce testcases.  Even
> then since you are adding code, it should be easy to find a testcase
> using the code you added.  I believe this should not have gone in
> without a testcase.  This violates one of our policies about having a
> testcase for every patch.

I don't have any copy of the test case.  I worked out the patch by
deduction based on what Tom reported.

Sometimes policies have to yield to reality.  But of course Tom may be
free to reduce and the test case himself.

Ian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]