This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
[patch] XFAIL two testcases in gcc testsuite.
- From: Kazu Hirata <kazu at codesourcery dot com>
- To: gcc-patches at gcc dot gnu dot org
- Cc: janis187 at us dot ibm dot com
- Date: Tue, 22 May 2007 12:23:10 -0700
- Subject: [patch] XFAIL two testcases in gcc testsuite.
Hi,
Attached is a patch to XFAIL two testcases in gcc testsuite.
Currently, gcc.c-torture/execute/ieee/20000320-1.c and
gcc.c-torture/execute/ieee/mul-subnormal-single-1.c are XFAILed when
they are run on m68k-linux-gnu, and we know that we are testing on a
ColdFire with an FPU.
It turns out that these testcases also fail on m68k-elf (i.e. bare
metal) if they are run on a ColdFire with an FPU. That makes sense
because these testcases check that the denormal numbers are correctly
generated, but ColdFire FPUs do not generate denormal numbers. (They
do give you an option of generating denormal numbers by software via
an interrupt hook.)
This patch widens the XFAILing a little bit. Specifically, with this
patch, the two testcases are XFAILed on any m68k-*-* as long as they
are run on a ColdFire with an FPU.
Tested individual testcases on m68k-elf. OK to apply?
Kazu Hirata
2007-05-22 Kazu Hirata <kazu@codesourcery.com>
* gcc.c-torture/execute/ieee/20000320-1.x,
gcc.c-torture/execute/ieee/mul-subnormal-single-1.x: XFAIL on
m68k-*-* and check_effective_target_coldfire_fpu.
Index: gcc/testsuite/gcc.c-torture/execute/ieee/mul-subnormal-single-1.x
===================================================================
--- gcc/testsuite/gcc.c-torture/execute/ieee/mul-subnormal-single-1.x (revision 124948)
+++ gcc/testsuite/gcc.c-torture/execute/ieee/mul-subnormal-single-1.x (working copy)
@@ -3,9 +3,9 @@ if [istarget "mips-sgi-irix6*"] {
# isn't expected to work for n32 and n64 on MIPS IV targets.
return 1
}
-if {[istarget "m68k-*-linux-gnu*"] && [check_effective_target_coldfire_fpu]} {
- # ColdFire FPUs require software handling of subnormals. Linux 2.6.10
- # does not have this.
- set torture_execute_xfail "m68k-*-linux-gnu*"
+if {[istarget "m68k-*-*"] && [check_effective_target_coldfire_fpu]} {
+ # ColdFire FPUs require software handling of subnormals. We are
+ # not aware of any system that has this.
+ set torture_execute_xfail "m68k-*-*"
}
return 0
Index: gcc/testsuite/gcc.c-torture/execute/ieee/20000320-1.x
===================================================================
--- gcc/testsuite/gcc.c-torture/execute/ieee/20000320-1.x (revision 124948)
+++ gcc/testsuite/gcc.c-torture/execute/ieee/20000320-1.x (working copy)
@@ -1,7 +1,7 @@
-if {[istarget "m68k-*-linux-gnu*"] && [check_effective_target_coldfire_fpu]} {
- # ColdFire FPUs require software handling of subnormals. Linux 2.6.10
- # does not have this.
- set torture_execute_xfail "m68k-*-linux-gnu*"
+if {[istarget "m68k-*-*"] && [check_effective_target_coldfire_fpu]} {
+ # ColdFire FPUs require software handling of subnormals. We are
+ # not aware of any system that has this.
+ set torture_execute_xfail "m68k-*-*"
}
return 0