This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: I don't understand some of gcc-4.1-20070514, a patch here.


2007/5/19, Eric Botcazou <ebotcazou@libertysurf.fr> wrote:
> Eric, what "reason previous stated"?

"loop.c is gone in the mainline sources.  Patching it on the 4.1 branch is
allowed only if you have a testcase that exposes a serious bug."

--
Eric Botcazou

Yes! There is an serious bug! It's illegible, unreadable, illogical, incomprehensible, dirty, heavy, ..

It's a testcase for humans but there is not a testcase for the machines.

For instance,
why loop_invariant_p and consec_sets_invariant_p are predicates
(or boolean functions)?
why use them inside of an logical expression?

The source code had exposed logical operations with not 2 values 0 and 1,
with 3 values 0, 1 and 2!

Sincerely yours, J.C.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]