This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [v3] PATCH to libstdc++ for forced unwind handling (c++/28145)
- From: Jason Merrill <jason at redhat dot com>
- To: Paolo Carlini <pcarlini at suse dot de>
- Cc: gcc-patches List <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 03 May 2007 11:47:10 -0400
- Subject: Re: [v3] PATCH to libstdc++ for forced unwind handling (c++/28145)
- References: <463982C2.5050002@redhat.com> <4639A040.2090106@suse.de>
Paolo Carlini wrote:
Please use __ios_base::badbit instead.
Thanks, thought I caught all of those.
I'm not sure we want to use here, and here only, the auto_ptr idiom. For
now, I would rather keep the current ("dumb") approach. Then we can
reconsider the thing, make sure we are including the minimal set of
memory headers for auto_ptr...
Well, it's either use auto_ptr or a custom class that just deletes the
pointer. If you'd rather I use a local class like in fstream::close
that's ok with me, but I figured since we already have that
functionality in the library I'd might as well use it.
> ... also, I'm pretty sure you want to touch try / catch blocks in
> src/*.cc files too...
Hmm, yes. I wonder why my grep didn't find those.
Jason