This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

[RFA/libiberty] use TOLOWER instead of tolower in filename_cmp.c

From: Joel Brobecker <brobecker at adacore dot com>
To: Ian Lance Taylor <iant at google dot com>
Cc: Eli Zaretskii <eliz at gnu dot org>, drow at false dot org, gcc-patches at gcc dot gnu dot org, gdb-patches at sourceware dot org
Date: Thu, 3 May 2007 08:36:17 -0700
Subject: [RFA/libiberty] use TOLOWER instead of tolower in filename_cmp.c
References: <20070405172720.GB9281@adacore.com> <ud52i4q62.fsf@gnu.org> <20070406061218.GB3471@adacore.com> <u3b3d50ul.fsf@gnu.org> <20070407173500.GC24650@caradoc.them.org> <u6488nkbm.fsf@gnu.org> <20070411072615.GB3648@adacore.com> <uabxelq94.fsf@gnu.org> <m31wiqabyd.fsf@localhost.localdomain>

> For locale-independent case conversion, use TOLOWER or TOUPPER in
> include/safe-ctype.h.

Thanks for the suggestion, Ian. Now that I'm back, here is a patch
that implements it.

2007-05-03  Joel Brobecker  <brobecker@adacore.com>

	* filename_cmp.c: Replace include of ctype.h by include of
	safe-ctype.h.
	(filename_cmp): Use TOLOWER instead of tolower for conversions
	that are locale-independent.
	* Makefile.in (filename_cmp.o): Add dependency on safe-ctype.h.

Tested on x86-linux and x86-windows. No regression.
OK to commit?

Thanks,
-- 
Joel

Attachment: tolower.diff
Description: Text document

Follow-Ups:
- Re: [RFA/libiberty] use TOLOWER instead of tolower in filename_cmp.c
  - From: Ian Lance Taylor
- Re: [RFA/libiberty] use TOLOWER instead of tolower in filename_cmp.c
  - From: Eli Zaretskii

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]