This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [gomp] Avoid -Wl,-z,nodlopen (PR libgomp/28482)


On Wed, May 02, 2007 at 10:17:44AM -0700, Richard Henderson wrote:
> On Wed, May 02, 2007 at 12:19:41PM -0400, Jakub Jelinek wrote:
> > I wonder if we additionally shouldn't change DATA_ALIGMENT on i386 (well,
> > we'd need a new macro so that the actual decl rather than type is passed)
> > to also take DECL_THREAD_LOCAL_P into account, TLS space is precious
> > and wasting bytes this way there is weird.
> 
> I agree, and that would prevent having to hack the alignment of
> the variable in the library.

Do you think this can be changed in generic code (i.e. DECL_THREAD_LOCAL_P
-> don't use DATA_ALIGNMENT)?

> > 	* configure.tgt: Don't link with -Wl,-z,nodlopen even on Linux.
> 
> I'm not fond of this, despite the python example recently posted
> to the list.  I think it's a good measure to help keep users from
> shooting themselves in the foot.

When you run out of the preallocated TLS space, dlopen on a DF_STATIC_TLS
library will just result in a dlopen failure, the same thing that happens
with DF_1_NOOPEN library, just the dlerror message will be different.

	Jakub


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]