Re: In-tree gmp builds broken (was: Re: [1/4] [patch, middle-end] Make mpz_set/get_double_int functions non-static.)

[Brooks Moses <brooks dot moses at codesourcery dot com>]

At 08:29 PM 4/30/2007, Hans-Peter Nilsson wrote:
> In-tree gmp broke with 124303:124306.
>
> > 2007-04-07  Brooks Moses  <brooks.moses@codesourcery.com>
> >
> >       double-int.c (mpz_set_double_int): Moved from
> >       tree-ssa-loop-niter.c.
> >       (mpz_get_double_int): Likewise.
> >       double-int.h: New prototypes for above.
>
> (Tsk tsk, doesn't mention the new #include gmp.h.)

Mea culpa.  And this provides quite a clear illustration of why that's 
important; I suspect I shall not forget again!  :)

[...]
> This bit causes in-tree gmp (where you untar gmp sources in the
> tree at the top-level and mv gmp-* gmp) to fail, because
> double-int.h is included in system.h, which is included in
> configure.ac tests, *but without the necessary -I flags to find
> gmp.h which isn't even built at this time*.  Hence all autoconf
> tests that #include "system.h" fail, and erroneous fall-back
> stuff is put in auto-host.h, causing compilation to fail for
> e.g. genmodes.o:
[...]
> Configury people, help!

One possible quick solution would be for me to simply move the functions 
that depend on GMP into some other file that's not included in system.h, so 
as to avoid the symptoms of the problem for now.

I suspect it's probably best to fix this "right", and I further would guess 
that if it's fixed "right" then it will work without moving the files, but 
I'd be glad to move them if the consensus seems to be 
otherwise.  Unfortunately, I know very little about the configury process, 
so I can't be of much help in that direction, though of course I'll do what 
I can if that seems to be the way to go.

In any case, thanks very much for your detailed analysis of the problem!

- Brooks