Re: [RFA:] Fix for Your libstdc++ testsuite changes causes regressions

[Nathan Sidwell <nathan at codesourcery dot com>]

Hans-Peter Nilsson wrote:
> :ADDPATCH libstdc++ testsuite:

> How did you perform that non-combined (newlib+gcc) build?  I'd
> like to know the verbatim commands.  And did you eventually try
> a combined (really: not-installed-newlib) tree?  It seems
> crucial in order to trig the bug, see the solution.

I've not got to trying a combined build (That was going to be this evening's 
entertainment :).   for the non-combined build I had separate binutils, gcc & 
newlib sources.  From memory the build was something like
*) config, build & install binutils
*) config gcc with --enable-languages=c, --with-newlib --disable-libssp 
--disable-libgomp --disable-a-couple-of-other-things
*) build & install that
*) config, build & install newlib with the just build gcc
*) go back to gcc and config with --enable-languages=c,c++ and the other options 
I mentioned
*) build that gcc, and now test it.

I'm sorry not to be more precise, but if I try to be, no doubt I'll mis-remember 
something and mislead you.

> The new regexp works with Tcl 8.4 series, 4 years old by now.
> Replacing the \s with " " makes it work with Tcl 8.0 too, but as
> long as we require "new" versions like dejagnu-1.4.4 that seems
> a bit of a stretch compatibilitywise.

ug, that original regexp is just such a hack.  Your patch looks ok to me.  I'm 
not an expert on tcl regexps, so don't know about the universality of the \s 
piece.  But I guess [ \t] would also work there.

thanks for figuring it out!

nathan

--
Nathan Sidwell    ::   http://www.codesourcery.com   ::         CodeSourcery
nathan@codesourcery.com    ::     http://www.planetfall.pwp.blueyonder.co.uk