This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] m68k: Add constraints.md.


On Mon, Apr 23, 2007 at 02:46:51AM -0400, Kazu Hirata wrote:
>      case RESULT_DECL:
>        decl_rtl = DECL_RTL (exp);
>        gcc_assert (decl_rtl);
> +      decl_rtl = copy_rtx (decl_rtl);

Hmm.  Ordinarily something like this would be fixed up by
unshare_all_decls, but this doesn't get called for globals.
You're probably unique in having full symbols be valid
references in some cases, and not in others.

Given that we go through the effort of unsharing them later,
I don't see that this is a bad patch at all.  Indeed, you
might be able to eliminate unshare_all_decls, if indeed you've
found the only place that needs fixing.


r~


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]