This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Pass -mmt/-mno-mt on to the MIPS assembler

Richard Sandiford wrote:
[snip]
> >> AFAICT, there's no need to make this RejectNegative and add -mno-mdmx
> >> separately.  It's OK with that removed and with Mask(MDMX) turned into
> >> Var(TARGET_MDMX).  (It doesn't need to be a mask, and some targets are
> >> short of bits.)
> >
> > Without RejectNegative it will accept (but ignore) -dmx and -mno-dmx,
> > this could collide with future use. I changed the Mask to a Var.
> 
> Doh!  Sorry, I'm an idiot.  I'd somehow misread it as "-mmdmx".
> 
> I just noticed:
> 
> Richard
> > +@itemx -mdmx
> > +@itemx -mno-mdmx
> 
> ...the first @itemx should be @item.
> 
> > +@itemx -mmt
> > +@itemx -mno-mt
> 
> ...same here.

Likewise in some other places nearby. I committed those as obvious.


Thiemo
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]