This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] pass @-files to collect2 and beyond, take 2

From: DJ Delorie <dj at redhat dot com>
To: mark at codesourcery dot com
Cc: gcc-patches at gcc dot gnu dot org, iant at google dot com
Date: Tue, 24 Apr 2007 14:57:56 -0400
Subject: Re: [PATCH] pass @-files to collect2 and beyond, take 2
References: <20070417200340.GM9017@sparrowhawk.codesourcery.com> <462D0E98.1010804@codesourcery.com>

> The gcc/ parts of this look good.  I've CC'd the libiberty
> maintainers; they may not have spotted this patch.

Nope, missed it.

My only comment is that writeargv() should be passed a FILE*, not a
file name, so that the application can do better error handling if the
file cannot be opened.  The proposed implementation has no way to tell
what caused the call to fail, just that it failed.  Also, the fclose()
isn't checked for errors.

Alternately, pass a name *and* a FILE*, requiring one to be NULL, and
have writeargv() do the right thing.

Follow-Ups:
- Re: [PATCH] pass @-files to collect2 and beyond, take 2
  - From: Nathan Froyd

References:
- [PATCH] pass @-files to collect2 and beyond, take 2
  - From: Nathan Froyd
- Re: [PATCH] pass @-files to collect2 and beyond, take 2
  - From: Mark Mitchell

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]