This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: patch: mingw support for I32/I64 MS printf formatters to c-format.c
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Kai Tietz <Kai dot Tietz at onevision dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Thu, 12 Apr 2007 18:45:04 +0000 (UTC)
- Subject: Re: patch: mingw support for I32/I64 MS printf formatters to c-format.c
- References: <OF282D8E42.811998E6-ONC12572BB.005FB828-C12572BB.005FFA99@onevision.de>
On Thu, 12 Apr 2007, Kai Tietz wrote:
> I suggest as first part of the patch to c-format.c the following. What are
> you think about this ?
You are adding a structure, variables and function without the required
comments, using an undocumented target macro. I have no idea what this
patch is supposed to be doing.
Start with user documentation for the new feature. Then the testsuite
changes that will be used to validate that the new feature has the desired
semantics. Then the documentation of any new target macros. Only then
the implementation.
--
Joseph S. Myers
joseph@codesourcery.com