This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: patch: mingw support for I32/I64 MS printf formatters to c-format.c
- From: Kai Tietz <Kai dot Tietz at onevision dot com>
- To: "Joseph S. Myers" <joseph at codesourcery dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Thu, 12 Apr 2007 17:45:48 +0200
- Subject: Re: patch: mingw support for I32/I64 MS printf formatters to c-format.c
"Joseph S. Myers" <joseph@codesourcery.com> wrote on 12.04.2007 17:25:42:
> On Thu, 12 Apr 2007, Kai Tietz wrote:
>
> > I see. Using a like mechanism in handle_format_attribute (), I could
> > simply override
> > the "printf", "strftime", and "scanf" attribute patterns by target
> > specific definitions.
> > Would this be an acceptable solution ?
>
> I can't tell which of the issues in my message you are answering.
> handle_format_attribute would be the appropriate place to detect and
> ignore a printf/scanf/strftime attribute being added to a function that
> already has a system_printf/system_scanf/system_strftime attribute with
> the same arguments.
Why do you think we should ignore rather than override those attributes by
extending the dynamic_format_types mechanism ? AFAICS this is always a
target
runtime issue, so that having a "system" and a none-"system" seems to be
just
an unnecessary duplication. Isn't it ? If there is a need to have a
doublicated
with different formatter rules, we could use also the TARGET_FORMAT_TYPES.
Regards,
i.A. Kai Tietz
------------------------------------------------------------------------------------------
OneVision Software Entwicklungs GmbH & Co. KG
Dr.-Leo-Ritter-StraÃe 9 - 93049 Regensburg
Tel: +49.(0)941.78004.0 - Fax: +49.(0)941.78004.489 - www.OneVision.com
Commerzbank Regensburg - BLZ 750 400 62 - Konto 6011050
Handelsregister: HRA 6744, Amtsgericht Regensburg
KomplementÃrin: OneVision Software Entwicklungs Verwaltungs GmbH
Dr.-Leo-Ritter-StraÃe 9 â 93049 Regensburg
Handelsregister: HRB 8932, Amtsgericht Regensburg - GeschÃftsfÃhrer:
Ulrike DÃhler, Manuela Kluger