This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PR 29585: C++ front end not setting TREE_ADDRESSABLE on vtbl entries
Mike Stump wrote:
> On Apr 10, 2007, at 7:18 PM, Mark Mitchell wrote:
>> So, let's just stomp on the type:
>>
>> ... build_address (...) ...
>> /* ??? We should call fold_convert to convert the address to
>> vtbl_ptr_type_node, which is the type of elements in the vtable.
>> However, the resulting NOP_EXPRs confuse other parts of the C++
>> front end. */
>> gcc_assert (TREE_CODE (vtbl) == ADDR_EXPR);
>> TREE_TYPE (vtbl) = vtbl_ptr_type_node;
>>
>> That patch is OK if it passes testing.
>
> Does the patch and results look ok to you?
Yes, this is OK; thanks.
I don't know what to say about some of the changes in results that you
saw. Are you sure the only change to your environment between test runs
was the patch in question? Certainly, the init5.C change seems odd, as
that test has no virtual functions. However, since the patch looks
correct to me, I think it is OK.
--
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713