This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: target/31478: Typo in sse2_umulv2siv2di3 pattern


H. J. Lu wrote:
Although mode in ix86_binary_operator_ok is ignored, V4SImode is less
confusing. Also Operands 1 and 2 of sdot_prodv8hi must be register.
Otherwise sse2_pmaddwd may fail when there are 2 memory operands.


H.J. ---- 2007-04-05 Uros Bizjak <ubizjak@gmail.com> H.J. Lu <hongjiu.lu@intel.com>

	PR target/31478
	* config/i386/sse.md (sse2_umulv2siv2di3): Use V4SImode instead
	of V8HImode when calling ix86_binary_operator_ok.
	(sdot_prodv8hi): Operands 1 and 2 must be register.

Could you also add

"TARGET_SSE2 && ix86_binary_operator_ok (MULT, V8HImode, operands)"

to sse2_pmaddwd pattern? This will prevent combine from generating MEM/MEM input operands.

Thanks,
Uros.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]