This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [wwwdocs] Document Waddress in GCC 4.2


On Sat, 31 Mar 2007, Manuel López-Ibáñez wrote:
The following patch documents the option -Waddress new in GCC 4.2

Looks good, thanks!


This is my first wwwdocs patch. Is it OK? Does wwdocs patches need a
changelog? How does commit work in this case?

Yes. No, a formal changelog is not required, a short description as part of the CVS commit is fine. Just go ahead and issue `cvs commit`, as for the regular codebase.

Gerald


PS: I have one comment, not on the patch but on warnings. For the following input

 struct C {
   int f() { return 1; }
 };

 int f(C &c) {
   return ( 1 == c.f );
 }

we currently issue

 In function 'int f(C&)':
 6: error: invalid use of member (did you forget the '&' ?)

In such a case, that is, for member functions, isn't adding the missing
() more likely than adding &?  Would you like me to create a Bugzilla for
this?

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]