This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: patch: sh wrong scheduling description


Kaz Kojima wrote:
Hi Christian,

Christian BRUEL <christian.bruel@st.com> wrote:

the attached patch fixes a scheduling performance issue with nofpu sh models.

Memory accesses was issuing a d_lock reservation instead of an sh4_load reservation. (Similarly the type for the mac constraints looks mixed up).


The patch looks fine, but please comment on how it has been tested.
Is it regtested on sh-elf?



oops indeed, I didn't mention that it was regtested for -m4 and -m4-nofpu on sh-superh-elf.


* config/sh/sh.md (movsi_i): Fix type attribute for r,m and x,< constraints.


"r,m and x,<" part may be a little confusing because they follow
source-destination order which is reverse to the operands order.
Simply "Fix type attribute." would be enough.


ok, thanks


Christian

Regards,
	kaz



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]