This is the mail archive of the
mailing list for the GCC project.
Re: patch: sh wrong scheduling description
- From: Christian BRUEL <christian dot bruel at st dot com>
- To: Kaz Kojima <kkojima at rr dot iij4u dot or dot jp>
- Cc: gcc-patches at gcc dot gnu dot org, aoliva at redhat dot com
- Date: Wed, 28 Mar 2007 12:57:04 +0200
- Subject: Re: patch: sh wrong scheduling description
- References: <460A2168.firstname.lastname@example.org> <email@example.com>
Kaz Kojima wrote:
Christian BRUEL <firstname.lastname@example.org> wrote:
the attached patch fixes a scheduling performance issue with nofpu sh
Memory accesses was issuing a d_lock reservation instead of an sh4_load
reservation. (Similarly the type for the mac constraints looks mixed up).
The patch looks fine, but please comment on how it has been tested.
Is it regtested on sh-elf?
oops indeed, I didn't mention that it was regtested for -m4 and
-m4-nofpu on sh-superh-elf.
* config/sh/sh.md (movsi_i): Fix type attribute for r,m and x,<
"r,m and x,<" part may be a little confusing because they follow
source-destination order which is reverse to the operands order.
Simply "Fix type attribute." would be enough.