This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH]: Updated new sparse bitmap patch

"Daniel Berlin" <dberlin@dberlin.org> writes:

> > > +      if (src1hasword && src2hasword)
> > > +     {
> > > +       tmpword = ebitmap_array_get (src1, src1eltindex++)
> > > +         | ebitmap_array_get (src2, src2eltindex++);
> >
> > Use parentheses to make emacs do the indentation correctly.
> It doesn't even if i parenthesize the calls (or the entire expression)
> Fixed anyway

When I write
  tmpword = (ebitmap_array_get (src1, src1eltindex++)
             | ebitmap_array_get (src2, src2eltindex++));
I get the correct parenthesization with emacs.


In any case, I'll approve this patch.  Give it a day or two before
committing to see if anybody else wants to say anything.

Thanks.

Ian
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]