This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [LTO] [PATCH] Avoid middle/back-end use of set_decl_assembler_name and tree_size lang hooks


Robert Kennedy wrote:
>> If you're referring to the code in init_one_libfunc, I think the fix is
>> simple, like so:
>>
>>   tree decl_name = get_identifier (name);
>>   tree decl = build_decl (FUNCTION_DECL, decl_name, ...);
>>   SET_DECL_ASSEMBLER_NAME (decl, decl_name);
>>   ...
>>
>> As you say, that must be right, since that's equivalent to what the C
>> front end does.
> 
> D'oh! Thanks for the gorgeous simplification that I should have seen
> for myself.
> 
> Here is a trimmed-down patch that doesn't contain the MBE_* ugliness.
> 
> OK for the LTO branch?

Yes, thanks!

-- 
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]