This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: A question on ACX_BUGURL
- From: "H. J. Lu" <hjl at lucon dot org>
- To: bonzini at gnu dot org
- Cc: Dave Korn <dave dot korn at artimi dot com>, 'Andreas Schwab' <schwab at suse dot de>, "'Joseph S. Myers'" <joseph at codesourcery dot com>, binutils at sources dot redhat dot com, gcc-patches at gcc dot gnu dot org
- Date: Mon, 26 Mar 2007 07:28:17 -0700
- Subject: Re: A question on ACX_BUGURL
- References: <20070323164757.GA1257@lucon.org> <Pine.LNX.4.64.0703231654580.829@digraph.polyomino.org.uk> <20070323171037.GA4610@lucon.org> <jelkhng7z9.fsf@sykes.suse.de> <20070323181039.GA11052@lucon.org> <007d01c76d77$e4c80cc0$2e08a8c0@CAM.ARTIMI.COM> <20070323185157.GA11298@lucon.org> <4607729A.6000107@lu.unisi.ch> <20070326140037.GA17325@lucon.org> <4607D2B0.5080004@lu.unisi.ch>
On Mon, Mar 26, 2007 at 04:03:28PM +0200, Paolo Bonzini wrote:
> H. J. Lu wrote:
> > On Mon, Mar 26, 2007 at 09:13:30AM +0200, Paolo Bonzini wrote:
> >> Please do this instead:
> >>
> >> REPORT_BUGS_TEXI=@uref{`echo "$BUGURL" | sed 's/@/@@/g'`}
> >>
> >
> > Will it work with spaces in $BUGURL?
>
> Yes, it will. You need quoting in the echo command, but
> not in the variable assignment. Quoting both the echo
> command-line and the variable assignment is not portable.
>
> Variable assignments (and case statements, as Andreas
> pointed out) do not perform word splitting of variables.
>
Here it is.
H.J.
----
2007-03-26 H.J. Lu <hongjiu.lu@intel.com>
* acx.m4 (ACX_BUGURL): Set BUGURL first. Quote $BUGURL first
when setting REPORT_BUGS_TEXI.
--- config/acx.m4.url 2007-03-24 09:18:59.000000000 -0700
+++ config/acx.m4 2007-03-26 07:21:24.000000000 -0700
@@ -577,16 +577,23 @@ AC_DEFUN([ACX_BUGURL],[
[Direct users to URL to report a bug]),
[case "$withval" in
yes) AC_MSG_ERROR([bug URL not specified]) ;;
- no) REPORT_BUGS_TO="";
- REPORT_BUGS_TEXI=""
+ no) BUGURL=
;;
- *) REPORT_BUGS_TO="<$withval>"
- REPORT_BUGS_TEXI="@uref{`echo $withval | sed 's/@/@@/g'`}"
+ *) BUGURL="$withval"
;;
esac],
- REPORT_BUGS_TO="<$1>"
- REPORT_BUGS_TEXI="@uref{`echo $1 | sed 's/@/@@/g'`}"
+ BUGURL="$1"
)
+ case ${BUGURL} in
+ "")
+ REPORT_BUGS_TO=
+ REPORT_BUGS_TEXI=
+ ;;
+ *)
+ REPORT_BUGS_TO="<$BUGURL>"
+ REPORT_BUGS_TEXI=@uref{`echo "$BUGURL" | sed 's/@/@@/g'`}
+ ;;
+ esac;
AC_SUBST(REPORT_BUGS_TO)
AC_SUBST(REPORT_BUGS_TEXI)
])