This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: patch: New pragma command for gcc


>>>>> "Kai" == Kai Tietz <Kai.Tietz@onevision.com> writes:

Kai> 2007-03-19  Kai Tietz  <Kai.Tietz@onevision.com>
Kai>   * c-pragma.c: (handle_pragma_push_macro): New functions.
Kai>     (handle_pragma_pop_macro): New functions.
Kai>     (init_pragma): Add new pragma command.
Kai>     (HANDLE_PRAGMA_PUSH_POP_MACRO): Handle macro option
Kai>     (def_pushpop_macro): New structure and typedef name
Kai>     (pushpop_macro_list): New static variable.

There's still a number of spots where this doesn't follow the GNU
coding standards.  At a glance it mostly seemed to be missing spaces,
e.g., there should be a space after the "if" here:

Kai> +  else if(token != CPP_STRING)

My real question, though, is why put this in gcc and not directly in
libcpp?  This extension seems to be directly preprocessor-related --
it could be useful anywhere cpp is useful, and AFAICS it doesn't need
anything in the C compiler itself.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]