This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: broken testcase gcc.dg/charset/attribute2.c

From: Eric Christopher <echristo at apple dot com>
To: Manuel López-Ibáñez <lopezibanez at gmail dot com>
Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>
Date: Tue, 20 Mar 2007 15:02:08 -0700
Subject: Re: broken testcase gcc.dg/charset/attribute2.c
References: <6c33472e0703201450h6f35db02ge8b12e4b53a9526c@mail.gmail.com>

On Mar 20, 2007, at 2:50 PM, Manuel López-Ibáñez wrote:

:ADDPATCH C:

Eric, as the person that added this testcase, is the fix below correct
or is this a regression?

I'm over here now :)

2007-03-14 Manuel Lopez-Ibanez <manu@gcc.gnu.org>
* gcc.dg/charset/attribute2.c: Fix wrong dg directive.
<fix-attribute2.diff>

Anyhow, I'm curious why an invalid attribute went from an error to a warning, but if that's the correct behavior then yes, the patch is correct. The patch is designed to test whether or not the attribute was translated.

-eric

Follow-Ups:
- Re: broken testcase gcc.dg/charset/attribute2.c
  - From: Manuel López-Ibáñez

References:
- broken testcase gcc.dg/charset/attribute2.c
  - From: Manuel López-Ibáñez

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]