This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Correct path relocation logic


Richard Sandiford wrote:

> gcc/
> 	* Makefile.in (PREPROCESSOR_DEFINES): Add directory terminators
> 	to PREFIX and STANDARD_PREFIX.
> 
> Index: gcc/Makefile.in
> ===================================================================
> --- gcc/Makefile.in	(revision 165665)
> +++ gcc/Makefile.in	(working copy)
> @@ -3033,8 +3033,8 @@ PREPROCESSOR_DEFINES = \
>    -DLOCAL_INCLUDE_DIR=\"$(local_includedir)\" \
>    -DCROSS_INCLUDE_DIR=\"$(CROSS_SYSTEM_HEADER_DIR)\" \
>    -DTOOL_INCLUDE_DIR=\"$(gcc_tooldir)/include\" \
> -  -DPREFIX=\"$(prefix)\" \
> -  -DSTANDARD_EXEC_PREFIX=\"$(libdir)/gcc\" \
> +  -DPREFIX=\"$(prefix)/\" \
> +  -DSTANDARD_EXEC_PREFIX=\"$(libdir)/gcc/\" \
>    @TARGET_SYSTEM_ROOT_DEFINE@

Yes, and thank you, and I apologize.

I actually had exactly this change in my original patch, and then took
it out because (by luck of how my environment was) it wasn't necessary.
 (I managed to get "/" into those variables anyhow.)  So, I checked in
my change.  Then, I thought that make_relative_prefix was wrong (see my
previous posting), but you and Alexandre have indicated that
make_relative_prefix is operating as expected.

In any case, sorry for the trouble.

Thanks,

-- 
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]