This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Handle splitting basic blocks in lower-subreg.c


On 09 Mar 2007 15:59:39 -0800, Ian Lance Taylor <iant@google.com> wrote:
>       * lower-subreg.c: Include except.h.
>       (decompose_multiword_subregs): Verify that the only control flow
>       insns we can split are loads to multi-words pseudos.
>       Handle breaking such blocks after splitting, instead of calling
>       find_many_sub_basic_blocks.

This is OK, except:

> +#ifdef ENABLE_CHECKING
> +      verify_flow_info ();
> +#endif

you don't need that, because the pass structs have TODO_verify_flow.
Or, if you want that anyhow, take out the TODO_verify_flow.

I've removed this check. I really just had it there to catch any problems as early as possible. But there were no problems: Bootstrapped&tested on x86_64 and powerpc32 linux. Commited as r122807 (along with the BB_SUPERBLOCK patch).

Thanks,

Gr.
Steven


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]