This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch, libgfortran] PR31052 Bad IOSTAT values when readings NAMELISTs past EOF


Steve Kargl wrote:
On Fri, Mar 09, 2007 at 08:43:01PM -0800, Jerry DeLisle wrote:
This problem was not quite what I originally thought. The function test_endfile was setting the endfile flag to AT_ENDFILE for the test case provided in the PR.

Commenting out test_endfile in st_rewind resolves the test case but regresses dev_null.f90. All other test cases past. So, it appears that test_endfile is needed for the special case when rewinding /dev/null. This seems weird to me to begin with, but how does one determine that a file is /dev/null?


I haven't read the PR nor your patch. But, if someone is trying to rewind /dev/null, he/she is an idiot. If it was me, I'd close the PR with a rather biting comment about stupidity.

Easy guy, its the existing dev_null.f90 in gfortran.dg thats doing this rewind. If you suggest we get rid of the rewind in there, then patching this PR is simply delete the call to test_endfile in st_rewind.

-- jerry


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]