This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [dataflow][RFC] missing update of subregs_of_mode


"Seongbae Park" <seongbae.park@gmail.com> writes:

> 2007-03-08  Seongbae Park <seongbae.park@gmail.com>
> 
>          * combine.c (gen_lowpart_for_combine): Remove update
>          of subregs_of_mode.
>          * passes.c (init_optimization_passes): Move
>          subregs_of_mode_init just before local-alloc.
>          Add a new pass subregs_of_mode_finish after global-alloc.
>          * regclass.c (cannot_change_mode_set_regs, invalid_mode_change_p):
>          Add a new assert.
>          (finish_subregs_of_mode): New function.
>          (pass_subregs_of_mode_finish): New pass structure.
>          * tree-pass.h (pass_subregs_of_mode_finish): Declaration for
> a new pass.

> +static unsigned int
> +finish_subregs_of_mode (void)
> +{
> +  subregs_of_mode = 0;
> +  return 0;
> +}

Seems like this should call htab_delete (subregs_of_mode).

Looks OK to me otherwise.

At some point find_subregs_of_mode should be rewritten to use
for_each_rtx.

Ian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]