This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [dataflow][RFC] missing update of subregs_of_mode
- From: Ian Lance Taylor <iant at google dot com>
- To: "Seongbae Park" <seongbae dot park at gmail dot com>
- Cc: "Kenneth Zadeck" <zadeck at naturalbridge dot com>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: 09 Mar 2007 08:11:56 -0800
- Subject: Re: [dataflow][RFC] missing update of subregs_of_mode
- References: <ab3a61990703071730t4f3de806ybfb6a0f35613c25e@mail.gmail.com> <45F00CF4.9080600@naturalbridge.com> <ab3a61990703081019n4c7d9090l6deb2fa5ba2a8026@mail.gmail.com>
"Seongbae Park" <seongbae.park@gmail.com> writes:
> 2007-03-08 Seongbae Park <seongbae.park@gmail.com>
>
> * combine.c (gen_lowpart_for_combine): Remove update
> of subregs_of_mode.
> * passes.c (init_optimization_passes): Move
> subregs_of_mode_init just before local-alloc.
> Add a new pass subregs_of_mode_finish after global-alloc.
> * regclass.c (cannot_change_mode_set_regs, invalid_mode_change_p):
> Add a new assert.
> (finish_subregs_of_mode): New function.
> (pass_subregs_of_mode_finish): New pass structure.
> * tree-pass.h (pass_subregs_of_mode_finish): Declaration for
> a new pass.
> +static unsigned int
> +finish_subregs_of_mode (void)
> +{
> + subregs_of_mode = 0;
> + return 0;
> +}
Seems like this should call htab_delete (subregs_of_mode).
Looks OK to me otherwise.
At some point find_subregs_of_mode should be rewritten to use
for_each_rtx.
Ian