This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
For what it's worth, I looked through the patch, and it looks good to me.Great! Thank you for looking into it.
I followed the style guide closely, but given that this is my first GCC patch, it is conceivable that there possibly might be a glitch :). Is there a lint-like style validation tool?I only looked at how it works though, i didn't go through the style with a fine tooth comb. :)
I will look for somebody else to do it. It is about 100 lines, almost entirely side-effect free, thus fairly easy to review.
I can't approve the frontend parts though, even though they look pretty simple.
Thank you, Silvius
Original post: http://gcc.gnu.org/ml/gcc-patches/2007-02/msg01477.html
-- Silvius Rus Google Inc. rus@google.com (650) 253-0159
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |