This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PING#3][PATCH][RFC] Warning for C++ malformed typedef [PR c++/23689]
- From: "Manuel López-Ibáñez" <lopezibanez at gmail dot com>
- To: "Simon Baldwin" <simonb at google dot com>
- Cc: "Nathan Sidwell" <nathan at codesourcery dot com>, gcc-patches at gcc dot gnu dot org
- Date: Thu, 1 Mar 2007 00:20:06 +0000
- Subject: Re: [PING#3][PATCH][RFC] Warning for C++ malformed typedef [PR c++/23689]
- References: <45E4AAF1.40209@google.com> <45E56206.6050301@codesourcery.com> <6c33472e0702280346n5a8fe2b9rf38b741af8a05961@mail.gmail.com> <45E61836.7020401@google.com>
On 01/03/07, Simon Baldwin <simonb@google.com> wrote:
Thanks for the note. Because DejaGNU seems to be limited to one
dg-something per line, it's a little messy to handle, but it's not terrible.
Don't be shy, you can say it: It is ugly. ;-)
I've modified the testsuite part of the patch slightly to filter typedef
warnings from existing tests a little better than in the original
version. Please take a look at the revised patch, attached, and see if
you think it'll be a bit more robust in the face of potential DejaGNU fixes.
If typedef2.C and the other testcases pass with those changes, I think
they are OK.
Since the patch was already approved, I believe you don't need further approval.
Thanks for implementing my suggestion.
Cheers,
Manuel.