Re: [PATCH] Do not set BB_SUPERBLOCK in loop-unroll.c:split_edge_and_insert

["Richard Guenther" <richard dot guenther at gmail dot com>]

On 2/26/07, Steven Bosscher <stevenb.gcc@gmail.com> wrote:
> > I would love to say that I will fix the problem for you, and perhaps I
> > will, if you are willing to wait for about two weeks (before I get rid
> > of some other work that pilled on me just now).
>
> I have no problem with waiting, but I can also fix the problem if I
> have a test case (I have a hackish patch, in fact). All I really want
> to see is whether any test suite failures show up somewhere, so that
> we have this code covered in the test suite.
>
> To be honest, I don't believe we'll have any test suite failures, or
> other problems.  But right now I see no other way to make sure, than
> by just trying. When something breaks after all, we can revert the
> patch for the moment and I can work on a proper fix (and of course I'd
> appreciate your help, if possible). But I can only fix a problem
> properly if I know that there is a problem to begin with.
>
> I really would not propose this unusual way forward if I would see a
> better way out...

I believe this is a reasonable way to go, if there's funny code in GCC nobody
knows why it's there and there's no testcase you can come up with that breaks
if removing it go ahead and remove it.  In the end GCC will be better because
we either removed some unneccesarry stuff or we finally get a testcase that
breaks.

Richard.