This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch, 4.1.2, 4.2.1, 4.3] Fix a bug in pointer dependency test


On 2/20/07, Ira Rosen <IRAR@il.ibm.com> wrote:


"Richard Guenther" <richard.guenther@gmail.com> wrote on 20/02/2007
12:21:48:

> On 2/19/07, Eric Botcazou <ebotcazou@adacore.com> wrote:
> > > Yes, I somehow missed these yesterday. It happens on powerpc too. I
will
> > > change the test case on 4.1, if there is no objection.
> >
> > I'm also seeing warnings on the 4.1 branch:
> >
> > /home/eric/gnat/gnat6_41/src/gcc/tree-ssa-alias.c: In function
> > 'may_aliases_intersect':
> > /home/eric/gnat/gnat6_41/src/gcc/tree-ssa-alias.c:2314: warning:
implicit
> > declaration of function 'pointer_set_create'
> > /home/eric/gnat/gnat6_41/src/gcc/tree-ssa-alias.c:2314: warning:
> > initializationmakes pointer from integer without a cast
> > /home/eric/gnat/gnat6_41/src/gcc/tree-ssa-alias.c:2316: warning:
> > initializationfrom incompatible pointer type
> > /home/eric/gnat/gnat6_41/src/gcc/tree-ssa-alias.c:2317: warning:
> > initializationfrom incompatible pointer type
> > /home/eric/gnat/gnat6_41/src/gcc/tree-ssa-alias.c:2323: warning:
implicit
> > declaration of function 'pointer_set_insert'
> > /home/eric/gnat/gnat6_41/src/gcc/tree-ssa-alias.c:2328: warning:
implicit
> > declaration of function 'pointer_set_contains'
> > /home/eric/gnat/gnat6_41/src/gcc/tree-ssa-alias.c:2330: warning:
implicit
> > declaration of function 'pointer_set_destroy'
>
> Not only warnings, but the branch is broken now, as may_aliases ()
returns
> a varray on the branch but you now have
>
>   VEC(tree,gc) *may_aliases1 = may_aliases (tag1);

Yes, I noticed that myself, and I was working on a fix. I am attaching it.

>
> Please revert the patch.

I can revert it, but maybe it's better to commit the fix?

The fix is ok with a proper ChangeLog entry and after bootstrapping and testing on the 4.1 branch (use --enable-werror).

Thanks,
Richard.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]