This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [m68k 04/13] libffi fixes and closure support
- From: Jeffrey Law <law at redhat dot com>
- To: zippel at linux-m68k dot org
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Tue, 06 Feb 2007 11:36:37 -0700
- Subject: Re: [m68k 04/13] libffi fixes and closure support
- References: <20070130112615.782382000@linux-m68k.org> <20070130114606.638872000@linux-m68k.org>
- Reply-to: law at redhat dot com
On Tue, 2007-01-30 at 12:26 +0100, zippel@linux-m68k.org wrote:
> Hi,
>
> The first part of this patch fixes numerous test suite failures,
> especially return value handling was broken for various types.
> The second part adds closure support.
>
> One question here might be about frame information handling, older
> assemblers don't support the cfi instructions, but I'd really like to
> avoid having to hardcode this like other ports, as this is impossible to
> maintain. Is there maybe a way to make this conditional?
>
>
> 2007-01-30 Roman Zippel <zippel@linux-m68k.org>
>
> * libffi/src/m68k/ffi.c (ffi_prep_args,ffi_prep_cif_machdep),
> libffi/src/m68k/sysv.S (ffi_call_SYSV): fix numerous test
> suite failures
> * libffi/src/m68k/ffi.c (ffi_prep_incoming_args_SYSV,
> ffi_closure_SYSV_inner,ffi_prep_closure), libffi/src/m68k/sysv.S
> (ffi_closure_SYSV,ffi_closure_struct_SYSV): New, add closure support
I'm really not the best person to review this.
Can someone more familiar with libffi step in, please?
Jeff