This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Remove TREE_COMPLEXITY, take 2
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Richard Kenner <kenner at vlsi1 dot ultra dot nyu dot edu>
- Cc: paolo dot bonzini at lu dot unisi dot ch, gcc-patches at gcc dot gnu dot org, stevenb dot gcc at gmail dot com
- Date: Mon, 5 Feb 2007 08:34:08 -0500
- Subject: Re: [PATCH] Remove TREE_COMPLEXITY, take 2
- References: <45C7265F.6090500@lu.unisi.ch> <10702051309.AA08992@vlsi1.ultra.nyu.edu>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Mon, Feb 05, 2007 at 08:09:01AM -0500, Richard Kenner wrote:
> Thanks for taking care of this.
>
> > I found that the required hash table functions are actually already
> > present in tree.c. There we have an implementation of a tree ->
> > unsigned short hash table; we need tree -> unsigned int instead but
> > it is not a problem to widen the values' type.
>
> That's probably correct, but who are the other users of that table? I'm
> concerned about the size expansion.
struct { tree x; unsigned short s; } and
struct { tree x; unsigned int s; } are the same size on all interesting
hosts, due to struct padding.
> > Since Richard K. is a GWP, and since by now TREE_COMPLEXITY is an
> > Ada-only thing (gigi-only) I placed in this patch also the actual
> > removal of TREE_COMPLEXITY.
>
> Has the OpenMP usage been removed? I haven't been able to keep track
> of of all of the back-and-forth on that issue.
Yes.
Jakub