This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [wwwdocs] IPA branch merge


On Fri, 26 Jan 2007, Jan Hubicka wrote:
> this should update webpages for IPA branch merge.

Thanks for taking care of this

> Index: index.html
> ===================================================================
> + <dt>January 25, 2007</dt>
> + <dd>Interprocedural optimization passes have been reorganized to operate on SSA
> +     This enables more precise function analysis and also optimization while
> +     inlining significantly improving performance of programs with high
> +     abstraction penalty.

"...and optimization while inlining, significantly improving the 
performance of programs with..."

(The additional comma makes quite a bit of a difference. ;-)  Also, please
try to avoid lines larger than 76 columns in general.)

> +     Code from <A HREF="http://gcc.gnu.org/wiki/ipa-branch";>ipa-branch</A>

<a href=...> </a>  (lower-case)

Instead of linking to that part of the Wiki, could you link to the
respective part of gcc-4.3/changes.html, or would that lose too much
information?  (You could always link from gcc-4.3/changes.html to the
Wiki.)

> +     contributed by Jan Hubicka, SUSElabs and Razya Ladelsky, IBM Haifa,

"SUSE Labs"

The entry is a bit longer than we'd usually like to have, but giving
proper acknowledgements to the reviewers is a nice idea.

> Index: gcc-4.3/changes.html
> ===================================================================
> +     <li>Inteprocedural optimizers was reorganized to work on functions in SSA
> + 	form.

"optimization was" and the line seems a bit long.

>             This enable more precise and cheaper dataflow analysis and makes
> + 	writing interprocedural optimizations easier.  Following improvements
> + 	has been implemented on the top of this framework:

"This enables"
"The following..." ..."have been"
"on top of" (without "the")

> + 	<ul>
> + 	 <li>Pre inline optimization: few local optimization passes are run
> + 	     before inliner (and other interprocedural passes) are executed.

"Pre-inline"?

"Few" -> "Selected"?

"inline" -> "the inliner"

> + 	     This significantly improves accuracy of code growth estimates used

"the accuracy"

> + 	     by inliner and reduce overall memory footprint for large

"the inliner"
"reduces"  "the overall memory footprint"

> + 	 <li>Early inlining (a simple bottom-up inliner pass inlining only
> + 	     functions whose body is smaller than expected call overhead) is

"than the expected"

> + 	     now executed in
> + 	     parallel with early optimization inlining optimized function bodies

Can you rephrase this?  Right now, it's a bit confusing, and I'm not 
really sure myself.

Perhaps "with the early optimization passes, thus inlining already
optimized function bodies"?

> + 	     into unoptimized function that is subsequently optimized by early

"into an"

> + 	     optimizers.  This enables compiler to quickly eliminate abstraction
> + 	     overhead in C++ programs.</li>

"the copmiler"
"abstraction overhead" -> "abstraction penality"?

> + 	 <li>Iterprocedural constant propagation now operate on SSA form
             ^^^^
             Inter

Okay with those changes.

Gerald


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]