Re: patches pending review November-January

[Dirk Mueller <dmueller at suse dot de>]

On Thursday, 1. February 2007 09:41, Manuel López-Ibáñez wrote:

> Wcomparison-fixed (try 2) (PR7651 Define -Wextra strictly in terms of
> other warning flags)
> http://gcc.gnu.org/ml/gcc-patches/2007-01/msg01933.html

Hmm, I don't like the inflation of -W*comparison* if we don't even have 
a -Wcomparison. At the least, -Wcomparison-fixed is inconsistent 
with -Wstring-literal-comparison (a very ugly name imho). 

We currently have a set of warnings that should perhaps be grouped together. 
now the obvious name would be -Walways-true (which we have already). 
Unfortunately -Walways-true also produces warnings about expressions that are 
always false (d'oh!). 

The next attempt would be to name it -Wcomparison, but it is not really a 
comparison we're talking about, right? it is an expression that is 
suspicious. The best names for such things is 
currently -Wsuspicious-expressions or -Widempotent, or (although in a way 
incorrect) -Wcomparison. 

Perhaps all those warnings should be consolidated 
under -Wsuspicious-expressions and -Wundefined-expressions ?



Dirk