This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch: PR preprocessor/30001


Tom Tromey wrote:

> 2006-12-22  Tom Tromey  <tromey@redhat.com>
> 
> 	PR preprocessor/30001:
> 	* charset.c (_cpp_convert_input): Check that to.len is greater
> 	than zero.

:REVIEWMAIL: OK

> +  if (to.len > 0 && to.text[to.len - 1] == '\r')

(Since to.len is unsigned, I'd probably just write "to.len" instead of
"to.len > 0"; as written, my first thought was "what does a negative
value mean?"  But, that's just me; even if you agree, it's almost
certainly not a good use of time to retest with that change.)

-- 
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]