This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] move superblock formation to Tree-SSA
- From: Jan Hubicka <hubicka at ucw dot cz>
- To: Robert Kidd <rkidd at crhc dot uiuc dot edu>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Wed, 27 Dec 2006 01:56:49 +0100
- Subject: Re: [PATCH] move superblock formation to Tree-SSA
- References: <7CA33963-EED3-4025-A2BA-1AA881F8F060@crhc.uiuc.edu>
Robert,
thanks for bringing tracer to SSA lavel. The implementation seems sane
to me (modulo the problem mentioned by Zdenek) and missing comments in
the front of new functions required by coding standard.
I wonder if you did some actual benchmarks comparing old and new tracer
behaviour? The placement in pass queue seems a bit early to me, since
tracer might actually confuse some other optimizations and thus it might
be profitable to move it down in the queue. It might be even profitable
to retain the current RTL functionality as we do for some other code
duplicating optimizations, such as unroller, so ther later tracer can
duplicate stuff that compiled to small code and was missed by earlier
tracing.
If it is problematic for you to run few benchmarks, I can do SPECs on
AMD64.
Thanks,
Honza