Re: Wambiguous-virtual-bases (PR7651 Define -Wextra strictly in terms of other warning flags)

["Manuel LÃpez-IbÃÃez" <lopezibanez at gmail dot com>]

On 24 Dec 2006 16:40:59 +0100, Gabriel Dos Reis
<gdr@integrable-solutions.net> wrote:
> "Manuel LÃpez-IbÃÃez" <lopezibanez@gmail.com> writes:
>
> | :ADDPATCH c++:
> |
> | This patch continues the effort to fix PR7651 [1].
> |
> | It adds a new option -Wambiguous-virtual-bases that takes over the
> | function of warning  about ambiguous virtual bases. The new option is
> | enabled by -Wextra, so we keep the current behaviour but add the
> | ability to enable/disable this
> | individual warning.
>
> OK, though the documentation should be improved -- the reason being
> that there is always only one instance of a virtual base class.  So
> speaking of ambiguous virtual base class is at first sight
> paradoxical,.

My knowledge of C++ is a bit rusty, so if you could propose something,
I will happily add it to the patch. I have just given it a name and
added testcases.

Cheers,

Manuel.