This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] DFP internal support for FP exceptions

From: Ben Elliston <bje at au1 dot ibm dot com>
To: Andrew Pinski <pinskia at gmail dot com>
Cc: Janis Johnson <janis187 at us dot ibm dot com>, gcc-patches at gcc dot gnu dot org
Date: Thu, 7 Dec 2006 10:41:24 +1100
Subject: Re: [PATCH] DFP internal support for FP exceptions
References: <20061201180642.GA4530@us.ibm.com> <1164996847.18220.17.camel@celery.andrew.com>

On Fri, Dec 01, 2006 at 10:14:07AM -0800, Andrew Pinski wrote:

> > +  if (DFP_EXCEPTIONS_ENABLED && context.status != 0)
> 
> Hmm, I would also use __builtin_expect here as I hope exceptions are
> rare.  Right now IIRC != 0 makes this branch a 50/50 change of going
> either way so it would be useful to mark this branch with
> __builtin_expect.

Ah, yes.  Please include this suggested change, Janis.

Cheers, Ben

References:
- [PATCH] DFP internal support for FP exceptions
  - From: Janis Johnson
- Re: [PATCH] DFP internal support for FP exceptions
  - From: Andrew Pinski

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]