This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Undefine MAX_OFILE_ALIGNMENT in config/arm/elf.h before overriding it
Mark Mitchell <mark@codesourcery.com> writes:
> Fred Fish wrote:
>> On Wednesday 06 December 2006 04:43, Richard Earnshaw wrote:
>>> On Tue, 2006-12-05 at 23:02 -0700, Fred Fish wrote:
>>>> MAX_OFILE_ALIGNMENT is now defined in elfos.h, which is included
>>>> before arm/elf.h, so we need to undefine it before overriding it.
>>>>
>>>> 2006-12-05 Fred Fish <fnf@specifix.com>
>>>>
>>>> * config/arm/elf.h (MAX_OFILE_ALIGNMENT): Undefine before defining.
>>> Hmm, no. I think we should just kill this definition. There's no
>>> technical reason for restricting this to a lower value than ELF can
>>> support.
>>
>> Fine with me. I only made it consistent with the other configs that
>> override MAX_OFILE_ALIGNMENT by first #undef'ing it.
>
> Coincidentally, Carlos was just working on a patch to do as Richard E.
> suggests. Carlos, would you please check that in on mainline? And,
> also the similar patch to mips.h that Richard S. approved?
For avoidance of doubt, no action is needed on the MIPS front.
The patch I approved was for sourcerygxx-4_1 only. The original
version of Carlos's patch defined MAX_OFILE_ALIGNMENT in mips.h
rather than elfos.h, and the patch I approved simply got rid of
that definition again.
Richard