This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: VRP speedup

From: Paolo Bonzini <paolo dot bonzini at lu dot unisi dot ch>
To: Richard Guenther <richard dot guenther at gmail dot com>
Cc: gcc-patches at gcc dot gnu dot org, dnovillo at redhat dot com
Date: Wed, 06 Dec 2006 11:15:33 +0100
Subject: Re: VRP speedup
References: <20061203142115.GA5242@kam.mff.cuni.cz> <84fc9c000612060137q6e6b6cddhbff38e0f594d692e@mail.gmail.com>

This should be return -2 (at least you check for that below and the
comment says so).  The patch also looks more like a hack to me ;)
But I guess until someone fixes fold-const.c to provide a special
fold-to-constant for comparisons it's still ok.

What about a better name, e.g. operand_less_p?

  /* Return true if value ranges VR0 and VR1 have a non-empty
!    intersection.
!
!    Benchmark compile/20001226-1.c compilation time after changing this
!    function.
!    */


Btw - are these comment changes a reminder for youself?  I don't think
they belong here (and above).

I think they do, if this is the heaviest code in 20001226-1.c right now.

Paolo

References:
- VRP speedup
  - From: Jan Hubicka
- Re: VRP speedup
  - From: Richard Guenther

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]