Re: [PATCH] Fix PR middle-end/28690, indexed load/store performance + reload bug

[Paolo Bonzini <paolo dot bonzini at lu dot unisi dot ch>]

> -	*addr = gen_rtx_PLUS (Pmode, *addr, base);
> +	{
> +	  /* For performance reasons on some processors, prefer
> +	     the pointer being the first operand of the PLUS.  */
> +	  if (REG_P (*addr) && !REG_POINTER (*addr)
> +	      && REG_P (base) && REG_POINTER (base))
> +	    *addr = gen_rtx_PLUS (Pmode, base, *addr);
> +	  else
> +	    *addr = gen_rtx_PLUS (Pmode, *addr, base);

In theory, given the change you made to rtlanal.c, this should be done with

  *addr = simplify_gen_binary (PLUS, Pmode, base, *addr);

If this does not work, it is probably because the 
swap_commutative_operands_p change does not affect other users of 
commutative_operand_precedence.

Paolo